Arrow-key seek, log hidden by default, loading status message

- Left/Right arrow keys skip -/+5s (clamped to file bounds), pausing
  first. QShortcut auto-repeats on its own while held, so no extra
  timer/logic was needed for 'hold to keep skipping'.
- ffmpeg log panel starts hidden (view_menu default flipped to
  unchecked) rather than visible by default.
- _load() now shows 'Loading <name>...' in the status bar and forces
  one repaint before the blocking mpv load call, then 'Loaded <name>'
  afterward -- player.load() itself stays synchronous, this just makes
  the wait visible instead of a silent freeze.

Also loosened an unrelated flaky assertion in smoke_test_ui.py: hr-seek
was observed landing within ~2 frames of the nominal target across
runs (decode-order/B-frame timing, not a regression), and the old
34ms/1-frame tolerance was tighter than that natural variance.
This commit is contained in:
ThePendulum
2026-07-26 02:10:24 +02:00
parent fdb858d88c
commit a9b9ef1ce9
4 changed files with 114 additions and 13 deletions
+24 -2
View File
@@ -204,6 +204,7 @@ class MainWindow(QMainWindow):
self.log_view.setReadOnly(True)
self.log_view.setMaximumHeight(120)
self.log_view.setPlaceholderText("ffmpeg output / warnings will appear here after export.")
self.log_view.setVisible(False)
layout.addWidget(self.log_view)
self.setCentralWidget(central)
@@ -211,7 +212,7 @@ class MainWindow(QMainWindow):
def _build_menu(self):
view_menu = self.menuBar().addMenu("&View")
self.toggle_log_action = QAction("Show ffmpeg Log", self, checkable=True, checked=True)
self.toggle_log_action = QAction("Show ffmpeg Log", self, checkable=True, checked=False)
self.toggle_log_action.toggled.connect(self.log_view.setVisible)
view_menu.addAction(self.toggle_log_action)
@@ -231,6 +232,10 @@ class MainWindow(QMainWindow):
QShortcut(QKeySequence(","), self, activated=lambda: self._step_frame(-1))
QShortcut(QKeySequence("."), self, activated=lambda: self._step_frame(1))
QShortcut(QKeySequence(Qt.Key.Key_Space), self, activated=self._toggle_play)
# QShortcut auto-repeats by default while the key is held, so this
# keeps skipping for as long as the arrow key is down.
QShortcut(QKeySequence(Qt.Key.Key_Left), self, activated=lambda: self._seek_relative(-5.0))
QShortcut(QKeySequence(Qt.Key.Key_Right), self, activated=lambda: self._seek_relative(5.0))
# -- transport -----------------------------------------------------
@@ -240,6 +245,13 @@ class MainWindow(QMainWindow):
self._load(path)
def _load(self, path: str):
# player.load() blocks the GUI thread until mpv reports the file's
# duration, so show the status message and force one repaint before
# starting it -- otherwise Qt wouldn't paint the message until after
# the blocking call already returned.
self.statusBar().showMessage(f"Loading {Path(path).name}…")
QApplication.processEvents()
self.input_path = path
self.player.load(path)
self.video_mark = None
@@ -259,7 +271,7 @@ class MainWindow(QMainWindow):
self.marker_strip.set_duration(duration)
self.marker_strip.clear()
self.statusBar().clearMessage()
self.statusBar().showMessage(f"Loaded {Path(path).name}", 4000)
self.detect_all_action.setEnabled(True)
self.detect_next_action.setEnabled(True)
@@ -280,6 +292,16 @@ class MainWindow(QMainWindow):
def _on_mute_toggled(self, checked: bool):
self.player.mpv.mute = checked
def _seek_relative(self, delta_seconds: float):
if self.input_path is None:
return
self.player.pause()
self.play_button.setText("Play")
duration = self.player.mpv.duration or 0.0
target = min(max(self.player.get_position() + delta_seconds, 0.0), duration)
self.player.seek(target)
self._update_position_ui()
def _on_slider_moved(self, value: int):
self.player.seek(value / 1000.0)
self._update_position_ui()